Implement Retry into Queue Lib #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PineappleIOnic
changed the title
eldadfux
requested changes
Dec 29, 2023
eldadfux
previously requested changes
Dec 29, 2023
Git ignored when I renamed it from e2e to E2E so I had to manually mv it using the cli
|
How is the retry strategy applied in production? As far as I can see here right now, is that we manually need to retry and it just works of all failed jobs. I am not sure if this is the most sane approach. Usually with all common libraries, the retry configuration is tied to a job. Meaning you enqueue a job while defining how its going to be retried. I am not sure if blindly just working of failed jobs is good. We dont know how many times a job has been retried, etc. ref: |
|
Right, I'll try and so some research and think of something better |
eldadfux
reviewed
Jan 5, 2024
christyjacob4
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Retry functionality into the Queue library, it will take all failed jobs in
{namespace}.failed.{queue}and re-queue them while removing them from that list.