Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scality storage adapter #65

Closed
wants to merge 20 commits into from
Closed

Scality storage adapter #65

wants to merge 20 commits into from

Conversation

misantron
Copy link

@misantron misantron commented Oct 23, 2022

@misantron
Copy link
Author

What is the point of using "minimum-stability": "dev" at Composer config?

@christyjacob4
Copy link
Contributor

Please sync your branch with main . It has fixes for the failing CI tests

@PineappleIOnic
Copy link
Member

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@stnguyen90
Copy link
Contributor

@misantron how's your progress on this?

@misantron
Copy link
Author

First of all Scality credentials required for passing the tests.

@misantron
Copy link
Author

Scality can be self-hosted or using public cloud as a backend. That's why we need to pass host to adapter. In some other PR I saw that you don't want to change constructor signature. How should I do this? Thanks.

@stnguyen90
Copy link
Contributor

Scality can be self-hosted or using public cloud as a backend. That's why we need to pass host to adapter. In some other PR I saw that you don't want to change constructor signature. How should I do this? Thanks.

@christyjacob4, thoughts on this?

@misantron
Copy link
Author

@christyjacob4, bump

# Conflicts:
#	src/Storage/Device/S3.php
# Conflicts:
#	composer.json
#	composer.lock
#	src/Storage/Device/Local.php
#	tests/Storage/S3Base.php
@christyjacob4
Copy link
Contributor

@misantron thanks a lot for your contributions during Hacktoberfest 2022!

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. 

Regarding the host issue, I believe its creating a limitation for self hosted instances of other storage adapters as well.

How about we pass an optional ?string $host parameter to the constructor and use it to override the default behaviour?

# Conflicts:
#	Dockerfile
#	composer.json
#	composer.lock
#	src/Storage/Device.php
#	src/Storage/Device/Local.php
#	src/Storage/Device/S3.php
#	src/Storage/Storage.php
#	src/Storage/Validator/File.php
#	src/Storage/Validator/FileExt.php
#	src/Storage/Validator/FileName.php
#	src/Storage/Validator/FileSize.php
#	src/Storage/Validator/FileType.php
#	src/Storage/Validator/Upload.php
#	tests/Storage/S3Base.php
#	tests/Storage/StorageTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🗄️ Extend Appwrite Storage with Scality Adapter
4 participants