-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scality storage adapter #65
Conversation
What is the point of using |
Please sync your branch with |
# Conflicts: # composer.lock
Thank you so much for the PR 🤩. We're adding the |
@misantron how's your progress on this? |
First of all Scality credentials required for passing the tests. |
Scality can be self-hosted or using public cloud as a backend. That's why we need to pass host to adapter. In some other PR I saw that you don't want to change constructor signature. How should I do this? Thanks. |
# Conflicts: # composer.lock
@christyjacob4, thoughts on this? |
# Conflicts: # src/Storage/Storage.php
@christyjacob4, bump |
# Conflicts: # src/Storage/Device/S3.php
# Conflicts: # composer.json # composer.lock # src/Storage/Device/Local.php # tests/Storage/S3Base.php
@misantron thanks a lot for your contributions during Hacktoberfest 2022! Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. Regarding the host issue, I believe its creating a limitation for self hosted instances of other storage adapters as well. How about we pass an optional |
# Conflicts: # Dockerfile # composer.json # composer.lock # src/Storage/Device.php # src/Storage/Device/Local.php # src/Storage/Device/S3.php # src/Storage/Storage.php # src/Storage/Validator/File.php # src/Storage/Validator/FileExt.php # src/Storage/Validator/FileName.php # src/Storage/Validator/FileSize.php # src/Storage/Validator/FileType.php # src/Storage/Validator/Upload.php # tests/Storage/S3Base.php # tests/Storage/StorageTest.php
Closes appwrite/appwrite#3987