Add better jni error reporting inside the godot editor

harness/tests/src/main/kotlin/godot/tests/exception/ExceptionTest.kt

@@ -0,0 +1,14 @@
+package godot.tests.exception
+
+import godot.Node
+import godot.annotation.RegisterClass
+import godot.annotation.RegisterFunction
+
+@RegisterClass
+class ExceptionTest: Node() {
+
+    @RegisterFunction
+    fun throwException() {
+        throw RuntimeException("Test exception")
+    }
+}

harness/tests/test/unit/test_exception.gd

@@ -0,0 +1,8 @@
+extends "res://addons/gut/test.gd"
+
+
+func test_exception_printing_in_editor() -> void:
+	var exception_test_script = load("res://scripts/godot/tests/exception/ExceptionTest.gdj").new()
+	exception_test_script.throw_exception()
+	assert_true(true) # fake assert; exception printed to console and godot editor
+	exception_test_script.free()

src/jni/env.cpp

@@ -38,8 +38,36 @@ namespace jni {
         return env->ExceptionCheck();
     }
 
-    void Env::exception_describe() {
+    String Env::exception_describe() {
+#ifdef TOOLS_ENABLED
+        jthrowable e = env->ExceptionOccurred();
+
+        if (e != nullptr) {
+            jclass string_writer_class {env->FindClass("java/io/StringWriter")};
+            jmethodID string_writer_constructor {env->GetMethodID(string_writer_class, "<init>", "()V")};
+            jobject string_writer {env->NewObject(string_writer_class, string_writer_constructor)};
+
+            jclass print_writer_class {env->FindClass("java/io/PrintWriter")};
+            jmethodID print_writer_constructor {env->GetMethodID(print_writer_class, "<init>", "(Ljava/io/Writer;)V")};
+            jobject print_writer {env->NewObject(print_writer_class, print_writer_constructor, string_writer)};
+
+            jclass throwable_class {env->FindClass("java/lang/Throwable")};
+            jmethodID print_stack_trace_method {env->GetMethodID(throwable_class, "printStackTrace", "(Ljava/io/PrintWriter;)V")};
+            env->CallVoidMethod(e, print_stack_trace_method, print_writer);
+
+            jmethodID to_string_method {env->GetMethodID(string_writer_class, "toString", "()Ljava/lang/String;")};
+            auto j_stack_trace_string {(jstring) env->CallObjectMethod(string_writer, to_string_method)};
+
+            const char* c_stack_trace {env->GetStringUTFChars(j_stack_trace_string, nullptr)};
+            String stack_trace {c_stack_trace};
+            env->ReleaseStringUTFChars(j_stack_trace_string, c_stack_trace);
+
+            return stack_trace;
+        }
+#else
         env->ExceptionDescribe();
+#endif
+        return {};
     }
 
     void Env::exception_clear() {
@@ -48,9 +76,13 @@ namespace jni {
 
     void Env::check_exceptions() {
         if (exception_check()) {
-            exception_describe();
+            String exception {exception_describe()};
             exception_clear();
-            HANDLE_JVM_EXCEPTIONS(true, "An exception has occurred!");
+
+            if (exception.is_empty()) {
+                exception = "An exception has occurred!";
+            }
+            HANDLE_JVM_EXCEPTIONS(true, exception);
         }
     }
 

src/jni/env.h

@@ -35,7 +35,7 @@ namespace jni {
         String from_jstring(jni::JString str);
 
         bool exception_check();
-        void exception_describe();
+        String exception_describe();
         void exception_clear();
 
         void check_exceptions();