Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues found in current buildd logs for grpn #11

Closed
getreu opened this issue Oct 19, 2018 · 2 comments
Closed

fix issues found in current buildd logs for grpn #11

getreu opened this issue Oct 19, 2018 · 2 comments
Labels
help wanted

Comments

@getreu
Copy link
Collaborator

getreu commented Oct 19, 2018 •
edited
Loading

buildd log scanner -- issues

buildd log scanner -- issues in package grpn -- Debian Quality Assurance

Snapshot of 20181020:

  • E pointer-trouble-at-implicit process_input.c:80
  • W dpkg-buildflags-missing CPPFLAGS 23 (of 23), CFLAGS 23 (of 23) missing (hppa, ia64)
  • W dpkg-buildflags-missing CPPFLAGS 23 (of 23), CFLAGS 23 (of 23), LDFLAGS 1 (of 1) missing
  • W implicit-declaration callback_buttons.c:67
  • W implicit-declaration funcs.c:840
  • W implicit-declaration main.c:93
  • W implicit-declaration process_input.c:193

Lintian Report

Lintian Report for Wartan Hachaturow
@getreu getreu mentioned this issue Oct 19, 2018
Closed
@utopiabound utopiabound mentioned this issue Nov 23, 2018
Merged
@utopiabound
Copy link
Owner

I've browsed through the issues listed above, and as far as I can tell between #12 and changes from 1.4.1 and 1.5.1 all the above warning/errors should be resolved.

getreu added a commit that referenced this issue Nov 24, 2018
@getreu
Merge pull request #12 from utopiabound/master
08e29ae 
Solves issue #11:
"fix issues found in current buildd logs for grpn"
[buildd log scanner -- issues in package grpn]

Tested architecture: amd64

[buildd log scanner -- issues in package grpn]:
https://qa.debian.org/bls/packages/g/grpn.html
@getreu
Copy link
Collaborator Author

getreu commented Nov 24, 2018 •
edited
Loading

In general PRs are easier to review when you have 1 PR per issue. Your PR looks Ok to me.
Thank you.
Lets wait that your patch goes through the Debian build system before closing this issue.

@getreu getreu closed this as completed Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@getreu @utopiabound