Linux 4.4 #14
Linux 4.4 #14
Conversation
code/utils/utils_c.c
Outdated
| #include "utils_c.h" | ||
| #include <linux/blk_types.h> | ||
|
|
||
| bool __c_is_async_write(struct disk_write_op_meta *m) { |
There was a problem hiding this comment.
Identifiers starting with _ are generally "reserved" by the compiler or the language. Could you please change these to start with something else?
(SO further reading here if you so desire)
code/cow_brd.c
Outdated
| @@ -417,9 +419,22 @@ static void brd_make_request(struct request_queue *q, struct bio *bio) | |||
| } | |||
| sector += len >> SECTOR_SHIFT; | |||
| } | |||
| #else | |||
There was a problem hiding this comment.
nit: please indent to be even with the code above, use 2 spaces per "tab" please :)
code/bio_alias.h
Outdated
| #define BI_SECTOR bi_sector | ||
| #define BIO_ENDIO(bio, err) bio_endio(bio, err) | ||
|
|
||
| #else |
There was a problem hiding this comment.
nit: please write a comment stating that this was originally written to target 4.4 kernels since there is no kernel version for this segment.
There was a problem hiding this comment.
I have changed the code to say exactly what versions of the kernel we know that work.
code/disk_wrapper.c
Outdated
| @@ -239,7 +240,19 @@ static void disk_wrapper_bio(struct request_queue* q, struct bio* bio) { | |||
| kunmap(bio_data); | |||
| copied_data += vec->bv_len; | |||
| } | |||
| #else | |||
| struct bio_vec vec; | |||
|
Hi @domingues, lets get this fixed and merged soon. I'd like you to start working on #1 next (assuming @ashmrtn doesn't have something else planned) |
Fix some indentation.
Added compatibility to Linux kernel 4.4.