Implement user checkpoints in CrashMonkey #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checkpoints made successfully when tested manually in background mode.
Make non-blocking socket read call.
It will now listen for checkpoint requests in tests CrashMonkey starts.
vijay03
requested changes
Oct 2, 2017
code/tests/checkpoint_example.cpp
Outdated
| @@ -162,13 +162,15 @@ class CheckpointExample : public BaseTestCase { | |||
| if (stat_old_res < 0 && errno_old == ENOENT && | |||
| stat_new_res < 0 && errno_new == ENOENT) { | |||
| test_res->SetError(DataTestResult::kFileMissing); | |||
| test_res->error_description = "test file has completely disappeared"; | |||
There was a problem hiding this comment.
Can we mention which file has disappeared? So is the file we are testing for always the same?
There was a problem hiding this comment.
This error is if the file does not exist at either the old or the new file path (the file is completely gone). I have updated the error string to note the file paths it is checking for the file.
code/tests/checkpoint_example.cpp
Outdated
| @@ -221,8 +230,10 @@ class CheckpointExample : public BaseTestCase { | |||
|
|
|||
| if (bytes_read != strlen(TEST_TEXT)) { | |||
| test_res->SetError(DataTestResult::kFileDataCorrupted); | |||
| test_res->error_description = check_file + ": read data size wrong"; | |||
There was a problem hiding this comment.
Lets print what the size should be, and what size is reported?
code/tests/checkpoint_example.cpp
Outdated
| } else if (memcmp(TEST_TEXT, buf, strlen(TEST_TEXT)) != 0) { | ||
| test_res->SetError(DataTestResult::kFileDataCorrupted); | ||
| test_res->error_description = check_file + ": read data incorrect"; |
There was a problem hiding this comment.
Similarly, lets print the index/prefix at which the buffers don't match
vijay03
approved these changes
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations for #42, #41, #40, #39, and #38.
Checkpoints can now be called from a helper binary in
build/user_tools/Checkpointor via the programmatic API withCheckpoint().The most recent checkpoint reached when generating a crash state is dumped to the output log along with the order of the bios used to generate the crash state (each bio is represented by its index in the original bio stream).
Below is an entry generated by running
sudo ./c_harness -f /dev/vda -d /dev/cow_ram0 -t ext2 tests/checkpoint_example.so. This test creates a file and a new directory, and then moves the new file between the root directory of the file system and the new directory. Checkpoints are placed at various intervals during this test.