Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added theme: nella-red #268

Closed
wants to merge 2 commits into from
Closed

added theme: nella-red #268

wants to merge 2 commits into from

Conversation

allenfrostline
Copy link

New theme developed in order to make utterance comment area more consistent with my blog's overall theme. Changes in yarn.lock not necessarily need merging though.

Copy link
Member

@jdanyow jdanyow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the theme- could you make a couple of changes:

  1. Remove the lock file from the PR
  2. Add the theme to end of the list of options in the configuration component:
    <select id="theme" class="form-select" value="github-light" aria-label="Theme">
    <option value="github-light">GitHub Light</option>
    <option value="github-dark">GitHub Dark</option>
    <option value="github-dark-orange">GitHub Dark Orange</option>
    <option value="icy-dark">Icy Dark</option>
    <option value="dark-blue">Dark Blue</option>
    <option value="photon-dark">Photon Dark</option>
    </select>

@allenfrostline
Copy link
Author

Hi can you review this PR? I need it approved before I can modify my website. Thank you!

@allenfrostline
Copy link
Author

allenfrostline commented Mar 29, 2020

@jdanyow Hi can you merge this PR when you've got time plz? It's been a whole month and my website updating is postponed basically because of lack of this theme for utterances. Thanks a lot 🤖

@allenfrostline
Copy link
Author

HI @jdanyow can you review and approve this PR? It's been months...

@jdanyow
Copy link
Member

jdanyow commented Nov 14, 2020

requested changes (yarn.lock) have not been addressed.

@allenfrostline
Copy link
Author

requested changes (yarn.lock) have not been addressed.

Hi I think I've delete that file from commit. Can you explain why it's not addressed yet? Thanks

@nschonni
Copy link
Contributor

image

You've got conflicts in 2 files. Probably need to do a rebase to resolve the issues. Probably editing the commits to remove the changes to the lock-file would be easiest

@allenfrostline
Copy link
Author

Closing with another PR #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants