add query names, new profile endpoints #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuazed
requested changes
Jul 27, 2021
| assert profile["username"] == "integration_test" | ||
|
|
||
|
|
||
| def test_daily_model_performances(api): |
There was a problem hiding this comment.
these tests are shooting actual api request, which isn't the best idea (I know, I also do that in other places.) Would be better to use mocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query names are needed to help us monitor backend performance (since graphql queries all go to the same endpoint).
Also added a couple new methods to use the new v3UserProfile and v2SignalsProfile endpoints