Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul codebase for v3 #46

Merged
merged 20 commits into from
Oct 10, 2023
Merged

Overhaul codebase for v3 #46

merged 20 commits into from
Oct 10, 2023

Conversation

uuf6429
Copy link
Owner

@uuf6429 uuf6429 commented Oct 8, 2023 •
edited

  • Fix all remaining test failures
  • Remove json (output) dependency
  • Remove html (output) dependency
  • Test that runs the example code in the readme (to ensure it does not get outdated)
  • Check coverage
  • Check/update readme
  • Ensure phpdoc types are resolved properly
  • Fix php 8 magic property deprecations

@uuf6429 uuf6429 changed the base branch from main to 3.x October 8, 2023 13:29
@uuf6429 uuf6429 changed the base branch from 3.x to main October 8, 2023 13:31
Repository owner deleted a comment from sonarcloud bot Oct 8, 2023
Repository owner deleted a comment from sonarcloud bot Oct 8, 2023
Repository owner deleted a comment from github-advanced-security bot Oct 8, 2023
@uuf6429 uuf6429 added this to the Milestone 3.0 milestone Oct 8, 2023
@sonarcloud

This comment was marked as outdated.

Sign in to view
1 similar comment
@sonarcloud

This comment was marked as outdated.

Sign in to view
@sonarcloud

This comment was marked as outdated.

Sign in to view
@uuf6429 uuf6429 marked this pull request as ready for review October 10, 2023 19:01
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 28 Code Smells

90.1% 90.1% Coverage
0.0% 0.0% Duplication

@uuf6429 uuf6429 merged commit c4feb68 into main Oct 10, 2023
10 checks passed
@uuf6429 uuf6429 deleted the modernize-codebase branch October 10, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Milestone 3.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@uuf6429