try to get wasm builds running #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
KodrAus
reviewed
Jan 17, 2019
| - cargo build --target wasm32-unknown-unknown --features "v3 wasm-bindgen" | ||
| - cargo build --target wasm32-unknown-unknown --features "v4 wasm-bindgen" | ||
| - cargo build --target wasm32-unknown-unknown --features "v5 wasm-bindgen" | ||
| - cargo web build --features "v3 stdweb" |
There was a problem hiding this comment.
Do you know what a simple cargo web build does differently than cargo build --target wasm32-unknown-unknown?
There was a problem hiding this comment.
Apparently there are hidden switches that are flipped around with cargo-web
The build failure particularly mentioned using it and it works
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Jan 17, 2019
358: try to get wasm builds running r=kinggoesgaming a=kinggoesgaming **I'm submitting a(n)** other # Description CI builds are failing because we are attempting to use `cargo build` for wasm builds. `cargo-web utility properly handles issues that are being caused # Motivation Failures while trying to pass #355 # Tests Current builds build in CI # Related Issue(s) N/A Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a(n) other
Description
CI builds are failing because we are attempting to use
cargo buildfor wasm builds. `cargo-web utility properly handles issues that are being causedMotivation
Failures while trying to pass #355
Tests
Current builds build in CI
Related Issue(s)
N/A