Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate byte-array-based namespaces passed into v3/5 #512

Closed
ctavan opened this issue Aug 22, 2020 · 2 comments
Closed

Validate byte-array-based namespaces passed into v3/5 #512

ctavan opened this issue Aug 22, 2020 · 2 comments

Comments

@ctavan
Copy link
Member

ctavan commented Aug 22, 2020

That byte-array-based namespaces aren't validated but string ones are is an inconsistency that should probably get addressed at some point so... yeah... @afterthought probably shouldn't count on this continuing to work in the future. But I don't see a compelling reason to close that particular loophole at the moment.

The alternative - adding an option to allow non-standard namespaces - flies in the face of the "this module adheres to the RFC" philosophy, so I'm a bit reticent to go that route.

'Kind of feels like we have a passable solution for the moment so maybe we can get away with looking the other way on this one until there's a reason to do otherwise. 🤷

Originally posted by @broofa in #511 (comment)

@josh-manton
Copy link

Is the above correct? It looks like it is reversed. string based uuids are getting passed to parse, while byte-array based name spaces by-pass parse and hence validate. The behavior should be the same, but I do believe that there should be a way to pass which validator you'd like, 'strict' which is fully RFC compliant, and 'lax' which only check the overall format of the string.

@broofa
Copy link
Member

broofa commented Aug 11, 2022

Closing until there's a reason to reopen.

@broofa broofa closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants