Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The test failed on the latest node version rng Browser without crypto.getRandomValues()' test fail #708

Closed
2 tasks done
rluvaton opened this issue Apr 11, 2023 · 1 comment · Fixed by #709
Closed
2 tasks done
Labels

Comments

@rluvaton
Copy link

rluvaton commented Apr 11, 2023

Before you begin...

  • I have searched the existing issues
  • I am not using version 13.x of node (if so, please upgrade)

Description of the problem

The test is failing on the latest node version (19.9.0):

test('Browser without crypto.getRandomValues()', () => {
assert.throws(() => {
rngBrowser();
});
});

as crypto is globally available, which causes the CITGM tests in node to fail.

related PR:

Recipe for reproducing

run:

nvm install 19.9.0
nvm use 19.9.0
npm test

Additional information

No response

Environment

No response

@rluvaton rluvaton added the bug label Apr 11, 2023
@rluvaton rluvaton changed the title [BUG] The rng Browser without crypto.getRandomValues()' test fail [BUG] The test failed on the latest node version rng Browser without crypto.getRandomValues()' test fail Apr 11, 2023
LinusU added a commit that referenced this issue Apr 12, 2023
@LinusU
Copy link
Member

LinusU commented Apr 12, 2023

Thank you for bringing this to our attention, potential fix is up here: #709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants