Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env: implement --ignore-signal #6164

Closed
sylvestre opened this issue Mar 31, 2024 · 5 comments · Fixed by #6377
Closed

env: implement --ignore-signal #6164

sylvestre opened this issue Mar 31, 2024 · 5 comments · Fixed by #6377
Labels
good first issue For newcomers! U - env

Comments

@sylvestre
Copy link
Sponsor Contributor 


       --ignore-signal[=SIG]
              set handling of SIG signal(s) to do nothing
@uutils uutils deleted a comment from radhesh1 May 2, 2024
@Walid-Kh
Copy link
Contributor

Walid-Kh commented May 7, 2024

Hi @sylvestre
I would like to work on this

@radhesh1
Copy link

radhesh1 commented May 7, 2024

Uhm did someone leave a comment for me?

@Walid-Kh
Copy link
Contributor

Walid-Kh commented May 7, 2024

Uhm did someone leave a comment for me?

I'm sorry were you working on this?

@radhesh1
Copy link

radhesh1 commented May 7, 2024 •
edited

You can work on this, I wanted to know about the deleted comment notification I got
IMG_1972

@cakebaker
Copy link
Contributor

cakebaker commented May 7, 2024 •
edited

@Walid-Kh sure, go ahead :)

@radhesh1: if I remember correctly, your comment was rather generic, something along "an interesting feature", and so it was probably removed for not adding anything to the issue at hand.

Walid-Kh added a commit to Walid-Kh/coreutils that referenced this issue May 7, 2024
@Walid-Kh
env: adds --ignore-signal
a30475d 
This commit immplement uutils#6164.
Walid-Kh added a commit to Walid-Kh/coreutils that referenced this issue May 7, 2024
@Walid-Kh
env: adds --ignore-signal
13f3cbe 
This commit immplement uutils#6164.
Walid-Kh added a commit to Walid-Kh/coreutils that referenced this issue May 7, 2024
@Walid-Kh
env: adds --ignore-signal
6cfb49d 
This commit implement uutils#6164.
@Walid-Kh Walid-Kh mentioned this issue May 7, 2024
Merged
@cakebaker cakebaker linked a pull request May 8, 2024 that will close this issue
env: adds --ignore-signal #6377
Merged
Walid-Kh added a commit to Walid-Kh/coreutils that referenced this issue May 20, 2024
@Walid-Kh
env: adds --ignore-signal
5e1a496 
This commit implement uutils#6164.
BenWiederhake pushed a commit that referenced this issue May 23, 2024
@Walid-Kh
env: adds --ignore-signal (#6377)
ebcd86d 
* env: adds --ignore-signal
This commit implement #6164.

* env: handle STOP signal and fix styling issue

* env: fix encoded bytes

* env: adds SAFETY comment and handle special signals in ignore_signal

* env: fix parsing to have compatible behaviour

* env: remove derive from Options

* env: changed safety comment, handle duplications after parsing and non-unix cfg

* env: adds tests for ignore-signal parsing and invalid and special signals

* env: change signal values to be non-constant

* env: adds testing for signal ignoring

* env: styling and remove unix specific derive

* test_env: add SIGSTOP to cspell workspace wordlist

* env: makes signal handling unix specific

* env: make ignore-signal function invocation unix specific

* test_env: make signal vector use slices ref instead of vec (linter)

* env: makes ignore-signal in options unix specific

* test_env: add unix specific import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For newcomers! U - env
Projects
Fuzz everything
Status: Done
GNU Compatibility
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

env: adds --ignore-signal Walid-Kh/coreutils
4 participants
@cakebaker @sylvestre @radhesh1 @Walid-Kh