New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(cp): implement archive & -L #1580
Conversation
Made progress, I am ignoring the error when it is a symlink. |
I am planning to land this Thursday 5st if no objection! |
I haven't really had the time to review this... (busy with COVID uptick at the hospitals). |
93aa309
to
dc03c90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor syntax change request, but I'm concerned that the tests are all "linux" gated.
@@ -491,3 +499,220 @@ fn test_cp_no_deref_folder_to_folder() { | |||
let path_to_check = path_to_new_symlink.to_str().unwrap(); | |||
assert_eq!(at.read(&path_to_check), "Hello, World!\n"); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, all the tests target only "linux"?
We definitely need to be testing all platforms. If there is some difficulty in getting them to work on MacOS/Windows, I can offer some time to help at a later date.
And, re-reading the docs, I think target_os = "unix"
is incorrect; it should be target_os = "linux"
.
"unix" is a target_family
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't know how to fix these :/
Symlinks are tricky on Windows
Sorry, I know this isn't perfect but this works and it is improving the overall code coverage. |
Real life test case: