Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup gnu test script #1701

Merged
merged 4 commits into from
Jan 21, 2021

Conversation

jaggededgedjustice
Copy link
Contributor

This fixes the last review comments from #1699

@sylvestre
Copy link
Sponsor Contributor

# TOTAL: 624
# PASS:  546
# SKIP:  62
# XFAIL: 0
# FAIL:  16
# XPASS: 0
# ERROR: 0

Are you sure you are really testing rust/coreutils?

@sylvestre
Copy link
Sponsor Contributor

That sounds too good to be true

@sylvestre sylvestre merged commit 2004601 into uutils:master Jan 21, 2021
@jaggededgedjustice
Copy link
Contributor Author

I can't see how anything would be going wrong, posibly the make to generate getlimits is messing things up? I did test that adding that make command wouldn't affect the binaries in the uutils build dir, but then again locally running lib/configmake.h src/getlimits was enough to get it the executable while in github there was another file that needed to be generated. So there might be remnants in my local test environment that is changing the results.
I'll run some experiments to confirm that the uutils binaries are what's being testsed.

@jaggededgedjustice jaggededgedjustice deleted the cleanup-gnu-test-script branch January 22, 2021 09:29
@tdulcet
Copy link

tdulcet commented Jan 22, 2021

That sounds too good to be true

Yeah, something is not right. Most of the factor tests should fail, since they test numbers > 264 - 1, which uutils factor does not currently support (#1559). Only two are currently failing.

You may want to try increasing the ulimit -t command, as some of the tests should take longer then 60 seconds.

@jaggededgedjustice
Copy link
Contributor Author

I have discovered my mistake. I was building uutils with cargo but that doesn't build all the individual binaries, so this is effectively testing the binaries that are installed on the system. After fixing this the tests just hang, a bit of digging indicates a fmt call was stuck in a read syscall which I assume is why the ulimit -t doesn't keep things moving.
I couldn't see an easy way to wrap individual tests with timeout, so I'll see if I can come up with a list of non-hanging tests.

@sylvestre
Copy link
Sponsor Contributor

@jaggededgedjustice ok, thanks for digging into that :)
Don't hesitate to report a bug about the fmt issue, we could just fix the problem

@sylvestre
Copy link
Sponsor Contributor

@jaggededgedjustice are you going to work on a fix to really use rust/coreutils?
Thanks

@jaggededgedjustice
Copy link
Contributor Author

Still working on it, I hope I've found the last problem and it just needs testing. If things work out I should have a PR over the weekend.

@tdulcet tdulcet mentioned this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants