Implement pr (resurrection of the resurrected PR)
#2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr: Add -h to print custom header instead of file name pr: Add -n to print line numbers
pr: code refactoring for references
…umbers pr: Add -l option set number of lines pr: Refactor opts
pr: Add -F to print line feed character for page separator
pr: Fix number of lines printed per page pr: Fix first short page getting skipped due to page range
pr: Remove parameter header from build_options pr: Remove unnecessary get_input_type
pr: Add test for -h option pr: Add test for -d option
pr: Fix long name for -n pr: Add -N first line number option pr: Add -n[char][width] support
pr: Fix page ranges
pr: Add test for -l option pr: Add test for -r suppress error option
pr: Print fixed padded string for each column pr: Fix display length vs str length due to tabs
|
Marking as draft because code coverage should be improved before merging. |
|
Expected: the gnu tests aren't running correctly but not a big deal: |
|
It seemed to be missing in the GNUMakefile, which should be fixed now, so hopefully it works now. |
|
Test coverage is not going to be perfect, but a lot will be fixed when we move this to |
|
Test coverage is rarely (never?) perfect ;) |
|
With 64 commits, I think it is time to land it :) |
flip1995
added a commit
to flip1995/coreutils
that referenced
this pull request
Jun 4, 2021
In PR uutils#2300 an old commit got merged putting back utilities that were already implemented into "To Do". This commit reverts this. In addition it moves `numfmt` to Semi-Done and sorts the Semi-Done column alphabetically. This should now be the up-to-date list of utilities. There are 96 utilities in Done or Semi-Done and `ls -1 src/uu | wc -l` also outputs 96.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A re-resurrection of #1918 by @MaxSem and @tilakpatidar. Let's get this merged after 2.5 years :)
I've brought it up to date with recent changes, fixed clippy lints and cleaned some of the code up. I think we can create a good first issue to move it to
claponce this is merged.