Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING: Add licensing details (#1994) #2493

Merged
merged 2 commits into from Jul 11, 2021

Conversation

dhodder
Copy link
Contributor

@dhodder dhodder commented Jul 10, 2021

Document existing practices around licensing, including making it clear
not to copy/reference GPL code.

Intended to resolve #1994.

Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I have one more question (maybe for @sylvestre): should we allow Apache 2.0 only dependencies?

CONTRIBUTING.md Outdated
@@ -25,6 +25,9 @@ search the issues to make sure no one else is working on it.
1. Don't hesitate to move common functions into uucore if they can be reused by other binaries.
1. Unsafe code should be documented with Safety comments.

uutils is original code. It cannot contain code from existing GNU or Unix-like
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this to the list instead of a separate paragraph?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@sylvestre
Copy link
Sponsor Contributor

great indeed! thanks for paying attention to licenses!

@dhodder
Copy link
Contributor Author

dhodder commented Jul 11, 2021

Great! I have one more question (maybe for @sylvestre): should we allow Apache 2.0 only dependencies?

This question has been asked in issue #2086. I don't know what the consensus is, it may even be a nuanced answer based on the dependency rather than a straight out yes or no. (See for example, the licensing policy of FreeBSD: they use BSD/ISC/MIT licensing but their core team allows Apache on a case-by-case basis.)

@tertsdiepraam
Copy link
Member

Issue #2086 was indeed why I brought it up. The main difference with MIT seems to be that you have to state the changes you make, so I'm leaning towards allowing it for dependencies, but not allowing copying code from Apache 2.0 projects. This ensures that we don't modify the code without stating the changes. Does that make sense?

@dhodder
Copy link
Contributor Author

dhodder commented Jul 11, 2021

Issue #2086 was indeed why I brought it up. The main difference with MIT seems to be that you have to state the changes you make, so I'm leaning towards allowing it for dependencies, but not allowing copying code from Apache 2.0 projects. This ensures that we don't modify the code without stating the changes. Does that make sense?

That makes sense to me. We could add a third license category, between "acceptable" and "licenses we will not use".

  • "Licenses accepted for references, on a case-by-case basis," or maybe
  • "Licenses accepted in referenced dependencies, when there is no obvious MIT alternative"?

@tertsdiepraam
Copy link
Member

Sounds good, but I'd like to hear what @sylvestre and @rivy think before we commit to that.

@sylvestre
Copy link
Sponsor Contributor

Sounds great! thanks :)

@sylvestre sylvestre merged commit ebaa05d into uutils:master Jul 11, 2021
@dhodder
Copy link
Contributor Author

dhodder commented Jul 11, 2021

Thank you @sylvestre and @tertsdiepraam .

@rivy , do you have any opinions please. Should we add a third license category to CONTRIBUTING.md between "acceptable" and "licenses we will not use":

Licenses accepted in referenced dependencies, on a case-by-case basis, when there is no MIT-licensed alternative:

  • Apache License, version 2.0

Thanks.

@dhodder dhodder deleted the licensing_doc branch July 22, 2021 14:22
dhodder added a commit to dhodder/coreutils that referenced this pull request Jul 22, 2021
Add a note the licensing section, stating that references using the
Apache License are acceptable on a case-by-case basis when there is no
MIT-licensed alternative.

  * Follow-up to uutils#1994 / uutils#2493

  * Intended to resolve issue uutils#2086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CONTRIBUTING: Make it clear not to copy/reference GPL code
3 participants