-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Redox #2550
Fixes for Redox #2550
Conversation
Excellent and looks great. Do you think it would be possible to add a check in the CI to prevent this from happening? |
@sylvestre this is not 100% building on Redox yet, because of awaiting upstream crate releases for filetime and termsize. When that is done, I can add the CI test required |
Excellent, thanks |
Here was the commit getting it working 100%, but at the cost of having to patch some crates: https://gitlab.redox-os.org/redox-os/uutils/-/commit/cfb9f9bc594395edc3afe442889506efa169e158 |
@jackpot51 I hope you are doing great. Do you know if we could have redox in the CI now ? :) |
We have windows stable in the CI: https://github.com/uutils/coreutils/runs/6082164374?check_suite_focus=true And no longer Redox: #2550
I will have to check if filetime and termsize ever got updated |
thanks! |
This contains a number of small fixes for Redox support. It should not affect other platforms, at all. After this, there are still some minor fixes I am waiting on other crates to implement before Redox builds could be enabled in CI.
I have organized the changes into small commits, please view and evaluate each commit by itself if the whole patchset does not make sense.