chgrp/chown: move common code to uucore
#2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miDeb
force-pushed
the
chgrp/no-duplication
branch
from
8f9b87c
to
c47fa16
Compare
jhscheer
reviewed
Aug 15, 2021
miDeb
force-pushed
the
chgrp/no-duplication
branch
from
5474668
to
d55ae0f
Compare
|
terrific idea, bravo! |
|
As far as I can tell those test failures are becuase the error messages now start with |
|
Could you please rebase this patch now that the other has been merged? |
miDeb
force-pushed
the
chgrp/no-duplication
branch
from
d55ae0f
to
fa10a20
Compare
miDeb
changed the title
uucore
chgrp does mostly the same as chown. By making chown a bit more configurable we can reuse its code for chgrp.
miDeb
force-pushed
the
chgrp/no-duplication
branch
from
fa10a20
to
4e25170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chgrp does mostly the same as chown.
By making chown a bit more configurable we can reuse its code for chgrp.
Closes #2565.
Depends on #2471 for correct error messages.