cp: handle edge cases when dest is a symlink #2610
Conversation
|
Sorry, it is conflicting, could you please fix that? thanks |
- Fail if dest is a dangling symlink - Fail if dest is a symlink that was previously created by the same invocation of cp
|
Should be fixed now! Sorry for being so slow, but since school started again I have much less time. |
|
The tests doesn't seem to have been run. Has the "rerun checks" button disappeared from GitHub? @miDeb could you check whether you can trigger them? |
|
I also can't find it. I'll try closing and reopening the PR, I think that should trigger a rerun. |
|
A test on windows seems to be failing because of a bug in |
|
Not sure why all CI jobs got cancelled, I'll rerun them once more... |
|
Interesting, GitHub retriggered the CI because I made another PR with the same commits. I'll close that one and merge this, because it's all green. |
| @@ -32,6 +35,114 @@ macro_rules! has { | |||
| }; | |||
| } | |||
|
|
|||
| /// Information to uniquely identify a file | |||
| pub struct FileInformation( | |||
There was a problem hiding this comment.
I just wanted to comment that this API is really nice :)
|
Thanks! |
uucorecat(fixes Cat Windows 10 does not work #2601)cpwhen the destination is a symlink.I also added some
FIXMEcomments tocpabout issues I found but didn't fix in this PR.