more: add next-line and prev-line command. #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
E3uka
commented
Dec 14, 2021
E3uka
commented
- Add next and previous line with 'j' and 'k' keys, respectively.
- Fixed small bug where a page down near the end of an open file causes over pagination.
tertsdiepraam
approved these changes
Dec 14, 2021
|
Happy to help!
I just did a quick man page check in comparing my current machine (Mac) and my other machine running WSL2, turns out the |
jfinkels
reviewed
Dec 16, 2021
| modifiers: KeyModifiers::NONE, | ||
| }) => { | ||
| if pager.should_close() { | ||
| return; |
There was a problem hiding this comment.
This caused a bug: it conflicts with the change in pull request #2767. This line now needs to return Ok(()); or similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.