ls: On Windows use metadata owned by DirEntry instead of retrieved one additionaly #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a unit test to cover this ? thanks |
moko256
force-pushed
the
moko256_ls_metadata_in_is_hidden
branch
from
ebbde34
to
5659bf8
Compare
|
Done, I added test for |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make
is_hiddento use theMetadatathatDirEntryhas instead of retrieved withstd::fs::metadataandstd::fs::symlink_metadata.With this change, the
Application Datafolder, that is symlink to hidden folder, will be hidden, that will same asdirbehavior in cmd.Also,
coreutils ls C:\will not panic. (it is probably issue instd::fs, but I came up with this PR when I was reproducing it.)The test from #1662 and #2441 should pass.