MSRV 1.56 #3350
Merged
MSRV 1.56 #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, tagging and upload would be great :) |
Yes, please. |
Never done it, but I'll try to do it in a bit! |
|
I am using util/update-version.sh & util/publish.sh to publish a new version |
|
Alright! I couldn't find the time to do it today, but I'll do it tomorrow. |
In Rust versions before 1.55, there was no enum for parse errors. With the bump of the MSRV to 1.56 we can simplify this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3342
We need to bump to 1.56 for the dependencies mentioned in that issue. However, because of how editions work, we don't necessarily need to switch to the 2021 edition for the dependencies to use the 2021 edition, so I left that out of this PR. I would propose that we switch soon after merging this though.
I have also included fixes for two places where a comment mentioned that it could be cleaned up once the MSRV would be bumped up.
Do we want to tag a new release before merging this?