Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

du: add support for --exclude and --exclude-from #3381

Merged
merged 8 commits into from
Apr 11, 2022

Conversation

sylvestre
Copy link
Sponsor Contributor

@sylvestre sylvestre commented Apr 9, 2022

And add an option --verbose (doesn't exist in GNU)
Fixes gnu test tests/du/exclude.sh & tests/du/slash.sh

Leverages glob

And add an option --verbose (doesn't exist in GNU)
@sylvestre sylvestre force-pushed the du-exclude branch 2 times, most recently from b0b9658 to 1d27e49 Compare April 9, 2022 19:11
@sylvestre
Copy link
Sponsor Contributor Author

Unexpected good news. I was only focusing on exclude.sh :)

Warning: Congrats! The gnu test tests/du/exclude is no longer failing!
Warning: Congrats! The gnu test tests/du/slash is no longer failing!

@sylvestre sylvestre requested a review from jfinkels April 9, 2022 23:45
src/uu/du/src/du.rs Outdated Show resolved Hide resolved
src/uu/du/src/du.rs Outdated Show resolved Hide resolved
@tertsdiepraam
Copy link
Member

Cool! I used globset before on ls and it was later removed due to binary size (#2781). Do you think it's worth the binary size in this case?

@sylvestre
Copy link
Sponsor Contributor Author

Oh, I forgot about globset size. I will have a look

@sylvestre sylvestre force-pushed the du-exclude branch 2 times, most recently from 4037bb0 to 27697b6 Compare April 10, 2022 21:23
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have a few suggestions, but this makes a lot of sense!

src/uu/du/src/du.rs Outdated Show resolved Hide resolved
src/uu/du/src/du.rs Outdated Show resolved Hide resolved
src/uu/du/src/du.rs Outdated Show resolved Hide resolved
src/uu/du/src/du.rs Outdated Show resolved Hide resolved
sylvestre and others added 3 commits April 11, 2022 20:01
@sylvestre sylvestre merged commit 8b719a8 into uutils:main Apr 11, 2022
@sylvestre sylvestre deleted the du-exclude branch April 11, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants