df: fix "Size" header for multiples of 1000 & 1024 #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
approved these changes
May 7, 2022
|
@jfinkels Feel free to merge these PRs if you think they're good! |
|
I'll consider that in the future, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the "Size" header for block sizes that are multiples of both 1000 and 1024. So far, such block sizes were handled as multiples of 1024 with the corresponding suffixes (e.g. "K", "M", "G"). Now they are handled as multiples of 1000 with suffixes like "kB", "MB", and "GB", in the same way as is done by GNU df.
Example:
128_000now becomes128kBinstead of125K.