Clap value hints #3524
Merged
Clap value hints #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equal-l2
reviewed
May 13, 2022
equal-l2
reviewed
May 13, 2022
tertsdiepraam
force-pushed
the
clap-value-hints
branch
from
50e1e17
to
0acfa07
Compare
|
@equal-l2 Thanks for your feedback! I've made the changes you requested. |
|
Looks like an excellent new feature, cool :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3503
I've not been super careful about every single argument, but I think I got most of them right. There might be some that are specified as
FilePatheven though they should beAnyPathor other small issues like that. I usedCommandNamefor all utils that invoke other commands, because I wasn't really sure what the differences betweenCommandName,CommandStringandCommandWithArgumentsare. UsingCommandNamefelt like a safe bet.