mktemp: simplify file path parameter logic #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
force-pushed
the
mktemp-simpler-prefix-suffix
branch
from
e3b6348
to
f4fd705
Compare
Simplify the logic of computing the file path parameters (the directory, prefix, suffix, and number of random characters) for the temporary file created by `mktemp`. This commits adds an `Options` struct as a layer of indirection between the application logic and `clap`, and a `Params` struct whose associated function is responsible for determining the file path parameters from the `Options`. This is an improvement because the previous code had some logic for determining file path parameters in one place and some in another place.
jfinkels
force-pushed
the
mktemp-simpler-prefix-suffix
branch
from
f4fd705
to
43e9fb7
Compare
|
better indeed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the logic of computing the file path parameters (the
directory, prefix, suffix, and number of random characters) for the
temporary file created by
mktemp. This commits adds anOptionsstruct as a layer of indirection between the application logic and
clap, and aParamsstruct whose associated function is responsiblefor determining the file path parameters from the
Options. This isan improvement because the previous code had some logic for
determining file path parameters in one place and some in another
place.
This change will help me finish the work started in pull request #3568.