-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ls: Remove unnecessary trailing space when using the comma format (-m) #3615
Conversation
unnecessary trailing space was being added. because we were padding for alignment, which is not required with -m fixes uutils#3608 Signed-off-by: anastygnome <noreplygitemail@protonmail.com>
Please add a test :) |
Hey, excuse me, I don't know how to. Sorry about that... |
You can just add a new test function to |
|
I mean I don't know how to do the thing we did with seq 2000 > file in the issue. |
Ah I see, I think it's best to do this in Rust code for the test. Something like this should work: let scene = TestScenario::new(util_name!());
let at = &scene.fixtures;
at.touch("some-file");
at.append("some-file", (0..2000).map(|x| x.to_string()).collect::<Vec<_>>().join("\n")) |
Signed-off-by: anastygnome <noreplygitemail@protonmail.com>
d1fb017
to
4c653d0
Compare
@sylvestre the failure is due to tail notify tests. This is good to merge, the trailing test is working fine |
f0f1e23
to
0ef6732
Compare
Bravo
|
unnecessary trailing space was being added. because we were padding for alignment,
which is not required with -m
fixes #3608
Signed-off-by: anastygnome noreplygitemail@protonmail.com