Update to handle all the latest cargo warnings #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
Jul 16, 2022
src/uu/factor/src/cli.rs
Outdated
| let stdin = stdin(); | ||
|
|
||
| for line in stdin.lock().lines() { | ||
| for line in stdin().lines() { |
There was a problem hiding this comment.
Error here:
use of unstable library feature 'stdin_forwarders'
There was a problem hiding this comment.
I removed this fix - clippy is not 100% happy still, but at least it is much closer to passing now.
There was a problem hiding this comment.
Clippy should take the MSRV into account with the suggestions is makes, so I think we're good. We'll start seeing them once we bump the MSRV.
sylvestre
reviewed
Jul 16, 2022
sylvestre
requested changes
Jul 18, 2022
andrewbaptist
force-pushed
the
fix_warnings
branch
3 times, most recently
from
c9da98b
to
77956b8
Compare
andrewbaptist
force-pushed
the
fix_warnings
branch
from
77956b8
to
cc08e1c
Compare
|
This PR should be good to go, the GnuTests failure is actually inaccurate (it is basing the output on PRs, not on main). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes ~100 different clippy lint warnings. Many of these may have been introduced by the clippy 1.64 release.