Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort: wait when SIGINT was raised for the program to finish properly #3801

Merged
merged 3 commits into from
Aug 10, 2022
Merged

sort: wait when SIGINT was raised for the program to finish properly #3801

merged 3 commits into from
Aug 10, 2022

Conversation

niyaznigmatullin
Copy link
Contributor

@niyaznigmatullin niyaznigmatullin commented Aug 10, 2022 •
edited

I think that test_tmp_files_deleted_on_sigint was failing, because sometimes the program finished before signal handling was finished, so the directory wasn't removed after all. I tested locally it was failing sometimes, after the fix I didn't see it failing.

  • Added wait for lock just before the program finishes if the lock was taken by the signal handler

@niyaznigmatullin niyaznigmatullin changed the title sort: wait if SIGINT was raised for the program to finish properly sort: wait when SIGINT was raised for the program to finish properly Aug 10, 2022
@sylvestre sylvestre merged commit e304758 into uutils:main Aug 10, 2022
@niyaznigmatullin niyaznigmatullin deleted the sort_wait_for_signal_handling branch August 14, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sort::test_tmp_files_deleted_on_sigint is intermittent
2 participants
@niyaznigmatullin @sylvestre