Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readlink: GNU compatibility #3826

Merged
merged 13 commits into from
Aug 16, 2022

Conversation

niyaznigmatullin
Copy link
Contributor

@niyaznigmatullin niyaznigmatullin commented Aug 15, 2022

  • Added checking for "Not a directory" error when using -e option and the given path is not a directory
  • Added checking for "Not a directory" error when using -f option and the parent of the given path is not a directory
  • Added tests for readlink and realpath for using trailing slashes
  • Fixed behavior when both --no-newline and --zero were used, it shouldn't print the delimiter even if it's --zero.
  • Added tests for delimiter options usage

Tests readlink/can-e.sh, readlink/can-f.sh and readlink/multi.sh should pass now

@niyaznigmatullin niyaznigmatullin changed the title fs/canonicalize: trailing slashes handling readlink: trailing slashes handling Aug 16, 2022
@niyaznigmatullin niyaznigmatullin changed the title readlink: trailing slashes handling readlink: GNU compatibility Aug 16, 2022
@sylvestre
Copy link
Sponsor Contributor

Indeed, bravo:

Warning: Congrats! The gnu test tests/readlink/can-e is no longer failing!
Warning: Congrats! The gnu test tests/readlink/can-f is no longer failing!
Warning: Congrats! The gnu test tests/readlink/multi is no longer failing!

@sylvestre sylvestre merged commit c03b3c4 into uutils:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants