tail: reuse opened file --follow=descriptor and renamed #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--follow=descriptor and renamed
niyaznigmatullin
force-pushed
the
fix_descriptor_vs_rename
branch
from
1bf631c
to
cdc6643
Compare
|
@jhscheer ok with you ? |
Yes, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed here #3798 (comment)
@jhscheer, I'm not sure we need
?, because it only happens when initially we couldn't open the file, so tail printedcannot open file for readingtelling about an error to the user. But there can be a case when the file has been renamed twice, for example, in which case we don't print anything now, but later on the next event we will print something.