Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stty: Implement printing assignment of control chars #5060

Merged
merged 1 commit into from Jul 17, 2023

Conversation

dezgeg
Copy link
Contributor

@dezgeg dezgeg commented Jul 8, 2023

Part of #3861

@github-actions
Copy link

github-actions bot commented Jul 8, 2023

GNU testsuite comparison:

Skipping an intermittent issue tests/tail-2/inotify-dir-recreate

@dezgeg dezgeg force-pushed the stty-control-chars branch 2 times, most recently from ab2ec87 to b1fe459 Compare July 9, 2023 09:57
src/uu/stty/src/stty.rs Outdated Show resolved Hide resolved
src/uu/stty/src/stty.rs Show resolved Hide resolved
@tertsdiepraam
Copy link
Member

Very cool to see stty get so much attention :) Nice work!

@dezgeg dezgeg force-pushed the stty-control-chars branch 5 times, most recently from 15c4afe to b8aa468 Compare July 10, 2023 22:17
src/uu/stty/src/flags.rs Outdated Show resolved Hide resolved
src/uu/stty/src/stty.rs Outdated Show resolved Hide resolved
@dezgeg dezgeg force-pushed the stty-control-chars branch 4 times, most recently from 2787fe4 to d2b7643 Compare July 15, 2023 17:36
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail-2/inotify-dir-recreate

Part of uutils#3861.

Code comments from sylvestre.

Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
@sylvestre
Copy link
Sponsor Contributor

is it too hard to write tests for these?

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail-2/inotify-dir-recreate

@dezgeg
Copy link
Contributor Author

dezgeg commented Jul 16, 2023

is it too hard to write tests for these?

Main problem is in the existing tests there isn't anything suitable to start modifying; existing cases either test fails that happen in argument parsing stage or are not run due to #[ignore = "Fails because cargo test does not run in a tty"]

@sylvestre sylvestre merged commit 1d171b5 into uutils:main Jul 17, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants