factor: short circuit on write error, but not on parse error
#5225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertsdiepraam
force-pushed
the
factor-short-circuit-write-error
branch
from
35cad3d
to
0507f99
Compare
tertsdiepraam
force-pushed
the
factor-short-circuit-write-error
branch
from
0507f99
to
9a67393
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix this line in the GNU tests:
which prints a lot of lines in the logs right now. (To be exact, 617,310 lines)
I've also removed
factors_buffer, which was originally added to ensure only full lines are being written. However, in my testing, the tests for that did not break (on my machine), so I figured all was good.