cp: compile without clap (for nushell) #5358

tommady · 2023-10-05T10:28:42Z

fulfill #5203

❯ cargo tree
uu_cp v0.0.21 (/home/arch/code/tommady/coreutils/src/uu/cp)
├── clap v4.4.2
│   └── clap_builder v4.4.2
│       ├── anstream v0.5.0
│       │   ├── anstyle v1.0.0
│       │   ├── anstyle-parse v0.2.0
│       │   │   └── utf8parse v0.2.1
│       │   ├── anstyle-query v1.0.0
│       │   ├── colorchoice v1.0.0
│       │   └── utf8parse v0.2.1
│       ├── anstyle v1.0.0
│       ├── clap_lex v0.5.0
│       ├── strsim v0.10.0
│       └── terminal_size v0.2.6
│           └── rustix v0.37.23
│               ├── bitflags v1.3.2
│               ├── io-lifetimes v1.0.11
│               │   └── libc v0.2.148
│               ├── libc v0.2.148
│               └── linux-raw-sys v0.3.8
├── filetime v0.2.22
│   ├── cfg-if v1.0.0
│   └── libc v0.2.148
├── indicatif v0.17.3
│   ├── console v0.15.7
│   │   ├── lazy_static v1.4.0
│   │   ├── libc v0.2.148
│   │   └── unicode-width v0.1.11
│   ├── number_prefix v0.4.0
│   ├── portable-atomic v0.3.15
│   └── unicode-width v0.1.11
├── libc v0.2.148
├── quick-error v2.0.1
├── uucore v0.0.21 (/home/arch/code/tommady/coreutils/src/uucore)
│   ├── clap v4.4.2 (*)
│   ├── dunce v1.0.4
│   ├── glob v0.3.1
│   ├── libc v0.2.148
│   ├── nix v0.27.1
│   │   ├── bitflags v2.4.0
│   │   ├── cfg-if v1.0.0
│   │   └── libc v0.2.148
│   ├── once_cell v1.18.0
│   ├── os_display v0.1.3
│   │   └── unicode-width v0.1.11
│   ├── uucore_procs v0.0.21 (proc-macro) (/home/arch/code/tommady/coreutils/src/uucore_procs)
│   │   ├── proc-macro2 v1.0.63
│   │   │   └── unicode-ident v1.0.5
│   │   ├── quote v1.0.29
│   │   │   └── proc-macro2 v1.0.63 (*)
│   │   └── uuhelp_parser v0.0.21 (/home/arch/code/tommady/coreutils/src/uuhelp_parser)
│   ├── walkdir v2.4.0
│   │   └── same-file v1.0.6
│   └── wild v2.2.0
├── walkdir v2.4.0 (*)
└── xattr v1.0.1
    └── libc v0.2.148

❯ cargo tree --no-default-features
uu_cp v0.0.21 (/home/arch/code/tommady/coreutils/src/uu/cp)
├── filetime v0.2.22
│   ├── cfg-if v1.0.0
│   └── libc v0.2.148
├── indicatif v0.17.3
│   ├── console v0.15.7
│   │   ├── lazy_static v1.4.0
│   │   ├── libc v0.2.148
│   │   └── unicode-width v0.1.11
│   ├── number_prefix v0.4.0
│   ├── portable-atomic v0.3.15
│   └── unicode-width v0.1.11
├── libc v0.2.148
├── quick-error v2.0.1
├── uucore v0.0.21 (/home/arch/code/tommady/coreutils/src/uucore)
│   ├── dunce v1.0.4
│   ├── glob v0.3.1
│   ├── libc v0.2.148
│   ├── nix v0.27.1
│   │   ├── bitflags v2.4.0
│   │   ├── cfg-if v1.0.0
│   │   └── libc v0.2.148
│   ├── once_cell v1.18.0
│   ├── os_display v0.1.3
│   │   └── unicode-width v0.1.11
│   ├── uucore_procs v0.0.21 (proc-macro) (/home/arch/code/tommady/coreutils/src/uucore_procs)
│   │   ├── proc-macro2 v1.0.63
│   │   │   └── unicode-ident v1.0.5
│   │   ├── quote v1.0.29
│   │   │   └── proc-macro2 v1.0.63 (*)
│   │   └── uuhelp_parser v0.0.21 (/home/arch/code/tommady/coreutils/src/uuhelp_parser)
│   ├── walkdir v2.4.0
│   │   └── same-file v1.0.6
│   └── wild v2.2.0
├── walkdir v2.4.0 (*)
└── xattr v1.0.1
    └── libc v0.2.148

src/uucore/src/lib/mods/error.rs

Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>

tertsdiepraam

Cool! I think there's a few bits missing:

clap is referred to in more parts of uucore:
- perms.rs
- shortcut_value_parser.rs
- backup_control.rs
- update_control.rs
Because of those, the dependency isn't actually removed. Try for instance cargo check --no-default-features in the src/uu/cp folder.
cli-parser should be a default feature on uucore, because otherwise none of the utils will compile individually. (Try for example cargo run --no-default--features --features arch)

src/uu/date/Cargo.toml

src/uu/cp/Cargo.toml

…n a dependency

tommady · 2023-10-06T06:02:25Z

Hi @tertsdiepraam
I am facing a problem ( or maybe just I don't know how

as you can see in the latest commit I tried to fulfill the requirements but still when you run

❯ cargo tree --no-default-features
uu_cp v0.0.21 (/home/arch/code/tommady/coreutils/src/uu/cp)
├── filetime v0.2.22
│   ├── cfg-if v1.0.0
│   └── libc v0.2.148
├── indicatif v0.17.3
│   ├── console v0.15.7
│   │   ├── lazy_static v1.4.0
│   │   ├── libc v0.2.148
│   │   └── unicode-width v0.1.11
│   ├── number_prefix v0.4.0
│   ├── portable-atomic v0.3.15
│   └── unicode-width v0.1.11
├── libc v0.2.148
├── quick-error v2.0.1
├── uucore v0.0.21 (/home/arch/code/tommady/coreutils/src/uucore)
│   ├── clap v4.4.2
│   │   └── clap_builder v4.4.2
│   │       ├── anstream v0.5.0
│   │       │   ├── anstyle v1.0.0
│   │       │   ├── anstyle-parse v0.2.0
│   │       │   │   └── utf8parse v0.2.1
│   │       │   ├── anstyle-query v1.0.0
│   │       │   ├── colorchoice v1.0.0
│   │       │   └── utf8parse v0.2.1
│   │       ├── anstyle v1.0.0
│   │       ├── clap_lex v0.5.0
│   │       ├── strsim v0.10.0
│   │       └── terminal_size v0.2.6
│   │           └── rustix v0.37.23
│   │               ├── bitflags v1.3.2
│   │               ├── io-lifetimes v1.0.11
│   │               │   └── libc v0.2.148
│   │               ├── libc v0.2.148
│   │               └── linux-raw-sys v0.3.8
│   ├── dunce v1.0.4
│   ├── glob v0.3.1
│   ├── libc v0.2.148
│   ├── nix v0.27.1
│   │   ├── bitflags v2.4.0
│   │   ├── cfg-if v1.0.0
│   │   └── libc v0.2.148
│   ├── once_cell v1.18.0
│   ├── os_display v0.1.3
│   │   └── unicode-width v0.1.11
│   ├── uucore_procs v0.0.21 (proc-macro) (/home/arch/code/tommady/coreutils/src/uucore_procs)
│   │   ├── proc-macro2 v1.0.63
│   │   │   └── unicode-ident v1.0.5
│   │   ├── quote v1.0.29
│   │   │   └── proc-macro2 v1.0.63 (*)
│   │   └── uuhelp_parser v0.0.21 (/home/arch/code/tommady/coreutils/src/uuhelp_parser)
│   ├── walkdir v2.4.0
│   │   └── same-file v1.0.6
│   └── wild v2.2.0
├── walkdir v2.4.0 (*)
└── xattr v1.0.1
    └── libc v0.2.148

under the cp folder, the clap dep stands still.

I tried a lot of ways to remove that but if any one of these features is used then the clap dep cannot be removed...

"entries"
"fs"
"mode"
"perms"
"update-control"
"backup-control"

please guide me when you have time.
thanks.

tertsdiepraam · 2023-10-06T14:50:54Z

I had to look around for a bit but I think this fixed it! Default features and workspaces are a bit weird together :)

diff --git a/Cargo.toml b/Cargo.toml
index e7fc2851b..2beaf7630 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -343,7 +343,7 @@ blake3 = "1.5.0"
 sm3 = "0.4.2"
 digest = "0.10.7"
 
-uucore = { version = ">=0.0.19", package = "uucore", path = "src/uucore" }
+uucore = { version = ">=0.0.19", package = "uucore", path = "src/uucore", default-features = false }
 uucore_procs = { version = ">=0.0.19", package = "uucore_procs", path = "src/uucore_procs" }
 uu_ls = { version = ">=0.0.18", path = "src/uu/ls" }
 uu_base32 = { version = ">=0.0.18", path = "src/uu/base32" }

tommady · 2023-10-07T04:57:56Z

I had to look around for a bit but I think this fixed it! Default features and workspaces are a bit weird together :)

diff --git a/Cargo.toml b/Cargo.toml
index e7fc2851b..2beaf7630 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -343,7 +343,7 @@ blake3 = "1.5.0"
 sm3 = "0.4.2"
 digest = "0.10.7"
 
-uucore = { version = ">=0.0.19", package = "uucore", path = "src/uucore" }
+uucore = { version = ">=0.0.19", package = "uucore", path = "src/uucore", default-features = false }
 uucore_procs = { version = ">=0.0.19", package = "uucore_procs", path = "src/uucore_procs" }
 uu_ls = { version = ">=0.0.18", path = "src/uu/ls" }
 uu_base32 = { version = ">=0.0.18", path = "src/uu/base32" }

wonderful it did! thanks!

src/uu/cp/Cargo.toml

Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>

…n a dependency

src/uu/cp/src/cp.rs

github-actions · 2023-10-16T09:53:30Z

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

src/uu/cp/Cargo.toml

sylvestre · 2023-12-25T12:08:10Z

@tommady sorry but it needs to be rebased

tommady added 3 commits October 5, 2023 10:14

let cp can without clap dep when no-default-features flag is specific

733066c

let uucore clap can be optional

1955616

let cp can optional out uucore clap

b29b31f

cakebaker linked an issue Oct 5, 2023 that may be closed by this pull request

cp: compile without clap (for nushell) #5203

Open

tommady added 2 commits October 5, 2023 11:31

let clap dep could be optional in the uucore

2f68fd4

fix date is using the uucore clap

fe47bf0

sylvestre reviewed Oct 5, 2023

View reviewed changes

src/uucore/src/lib/mods/error.rs Show resolved Hide resolved

Update src/uucore/src/lib/mods/error.rs

4cb66c4

Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>

tommady marked this pull request as ready for review October 5, 2023 12:13

tertsdiepraam reviewed Oct 5, 2023

View reviewed changes

src/uu/date/Cargo.toml Outdated Show resolved Hide resolved

src/uu/cp/Cargo.toml Outdated Show resolved Hide resolved

tommady added 3 commits October 6, 2023 02:35

use dep:clap instead of just a clap to mark this feature is depends o…

d867b1b

…n a dependency

fix-5203 but cargo tree --no-default uucore still has clap dep

4362184

Merge branch 'fix-5203' of github.com:tommady/coreutils into fix-5203

9f0f0a9

fixing clippy and check errors

af8690d

tertsdiepraam mentioned this pull request Oct 7, 2023

allow a deeper integration with nushell #5088

Open

cakebaker reviewed Oct 15, 2023

View reviewed changes

src/uu/cp/Cargo.toml Outdated Show resolved Hide resolved

tommady and others added 10 commits October 16, 2023 10:48

let cp can without clap dep when no-default-features flag is specific

968e901

let uucore clap can be optional

fea371a

let cp can optional out uucore clap

27e2dc4

let clap dep could be optional in the uucore

ee93c10

fix date is using the uucore clap

33db724

Update src/uucore/src/lib/mods/error.rs

e28c71d

Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>

use dep:clap instead of just a clap to mark this feature is depends o…

243fa6a

…n a dependency

fix-5203 but cargo tree --no-default uucore still has clap dep

51cf10f

fixing clippy and check errors

c08de95

cp: fix formatting of Cargo.toml

20735c9

sylvestre force-pushed the fix-5203 branch from 41744cc to 20735c9 Compare October 16, 2023 08:48

sylvestre reviewed Oct 16, 2023

View reviewed changes

src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved

tommady added 5 commits October 16, 2023 10:24

remove temp unused allow(dead_code)

10f5d98

Merge branch 'fix-5203' of github.com:tommady/coreutils into fix-5203

e38bcf3

remove temp unused allow(dead_code)

fea1a2e

fix the style toml check

7c2adb5

Merge branch 'main' into fix-5203

a54dd0e

cakebaker reviewed Oct 17, 2023

View reviewed changes

src/uu/cp/Cargo.toml Outdated Show resolved Hide resolved

cp: fix formatting of Cargo.toml

7f5d90a

tommady added 2 commits December 26, 2023 11:17

Merge branch 'main' into fix-5203

8ca000e

fix cargo fmt

8efa790

sylvestre requested a review from tertsdiepraam January 14, 2024 22:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cp: compile without clap (for nushell) #5358

cp: compile without clap (for nushell) #5358

tommady commented Oct 5, 2023

tertsdiepraam left a comment •

edited

tommady commented Oct 6, 2023

tertsdiepraam commented Oct 6, 2023

tommady commented Oct 7, 2023

github-actions bot commented Oct 16, 2023

sylvestre commented Dec 25, 2023

cp: compile without clap (for nushell) #5358

Are you sure you want to change the base?

cp: compile without clap (for nushell) #5358

Conversation

tommady commented Oct 5, 2023

tertsdiepraam left a comment • edited

Choose a reason for hiding this comment

tommady commented Oct 6, 2023

tertsdiepraam commented Oct 6, 2023

tommady commented Oct 7, 2023

github-actions bot commented Oct 16, 2023

sylvestre commented Dec 25, 2023

tertsdiepraam left a comment •

edited