tests/test: Ensure the test fixture files have the expected gid #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checking the cspell failure. |
n1000
force-pushed
the
freebsd_fixes_push_3
branch
from
33e3994
to
1adebef
Compare
|
Fixed the cspell failure. |
|
Reviewed the failures for FreeBSD -- it looks like the test runner's primary group is "wheel", that explains why I see a different result on my local FreeBSD system and the pre commit tests. I am thinking for this specific |
n1000
force-pushed
the
freebsd_fixes_push_3
branch
from
1adebef
to
3480ade
Compare
|
I think the remaining failures might be an test infra issue (unless I missed one). |
|
@sylvestre I don't know much about these things. Does this look good to you? |
n1000
force-pushed
the
freebsd_fixes_push_3
branch
from
3480ade
to
76c7f49
Compare
On some platforms (mostly the BSDs) the test fixture files copied to the /tmp directory will have a different gid than the current egid (due to the sticky bit set on the /tmp directory). Fix this before running the "test" command.
sylvestre
force-pushed
the
freebsd_fixes_push_3
branch
from
76c7f49
to
1915e3c
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms (mostly the BSDs) the test fixture files copied to the /tmp directory will have a different gid than the current egid (due to the sticky bit set on the /tmp directory). Fix this before running the "test" command.