wc: pass GNU test wc-proc and Windows optimization #5612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
Nice, did you do some benchmarking on windows? thanks |
thanks! nothing rigorous, but just compared on my Win11Pro ARM VM and on 85MB file it is about 3x faster (on the cold start and unoptimized debug build). Should be much faster on files with sizes in GBs / TBs |
|
@sylvestre @tertsdiepraam would you mind looking it over? Thanks! |
|
GNU testsuite comparison: |
sylvestre
reviewed
Dec 7, 2023
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
|
GNU testsuite comparison: |
|
excellent, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wc -c) use filesystem's metadata file size instead of full file read - for regular files