ls: unquoted names should be indented with a space if there is a quoted name #5740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the old commits :) |
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 29, 2023
cakebaker
force-pushed
the
ls_indentation
branch
from
940b028
to
193307e
Compare
|
Ok, I removed the old commits from this branch. |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5632 fix.
In short, I added a boolean variable
quotedwhich is true if at least one file name is displayed between quotes. If so, all unquoted filenames are formatted so that they have an extra leading space, as GNU's ls does.Unfortunately I couldn't find a way to write unit tests for this functionality because ls formats output differently when it's not stdout. I tried using different flags ("-C", "--quoting-style", "-T") but couldn't find a way to make ls format properly.