ls: if acl are used, show the + in the perms #5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fails because we are doing much more getxattr (22 instead of 3) |
sylvestre
force-pushed
the
acl
branch
6 times, most recently
from
91eac5e
to
b58fa9c
Compare
|
I think it is now good |
|
and I realized that GNU isn't testing this. So, I added a test upstream: |
|
I don't know whether you have seen it: some |
|
I missed it, thanks :) |
cakebaker
reviewed
Jan 12, 2024
cakebaker
reviewed
Jan 12, 2024
cakebaker
reviewed
Jan 12, 2024
cakebaker
reviewed
Jan 12, 2024
Tested by tests/mkdir/p-acl.sh
|
Needs a rebase :| |
cakebaker
approved these changes
Jan 14, 2024
|
GNU testsuite comparison: |
sylvestre
added a commit
to sylvestre/coreutils
that referenced
this pull request
Jan 19, 2024
* ls: if acl are used, show the + in the perms Tested by tests/mkdir/p-acl.sh * CICD.yml: fix small formatting issue --------- Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by tests/mkdir/p-acl.sh