cp: --preserve should keep xattr #5834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Merged
sylvestre
commented
Jan 13, 2024
| @@ -3701,3 +3703,57 @@ fn test_cp_no_such() { | |||
| .fails() | |||
| .stderr_is("cp: 'no-such/' is not a directory\n"); | |||
| } | |||
|
|
|||
| #[cfg(all(unix, not(target_os = "macos")))] | |||
| fn compare_xattrs<P: AsRef<Path>>(path1: P, path2: P) -> bool { | |||
There was a problem hiding this comment.
i will update this code to use the one in
#5835
after this one is merged
sylvestre
force-pushed
the
cp-acl
branch
2 times, most recently
from
d6854e9
to
8a31fea
Compare
|
GNU testsuite comparison: |
Should help with tests/cp/acl.sh
|
GNU testsuite comparison: |
Kudos :) |
cakebaker
reviewed
Jan 14, 2024
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
cakebaker
reviewed
Jan 14, 2024
cakebaker
reviewed
Jan 14, 2024
There was a problem hiding this comment.
Is it the expected behavior that the test doesn't fail if the changes in cp.rs are not applied?
There was a problem hiding this comment.
yeah, i am planning to fix mac and the tests once they land :)
cakebaker
reviewed
Jan 14, 2024
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
|
GNU testsuite comparison: |
sylvestre
added a commit
to sylvestre/coreutils
that referenced
this pull request
Jan 19, 2024
* cp: --preserve should keep xattr Should help with tests/cp/acl.sh * Update tests/by-util/test_cp.rs Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com> * Update tests/by-util/test_cp.rs Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com> * Update tests/by-util/test_cp.rs Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com> --------- Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with tests/cp/acl.sh