Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad reCaptcha error in version Stable Release v1.0.14. How to reverse back? #424

Closed
PeopleInside opened this issue Jun 23, 2021 · 9 comments

Comments

@PeopleInside
Copy link
Contributor

PeopleInside commented Jun 23, 2021

I upgraded UVdesk from v1.0.13 to v1.0.14

Now on ticket creation if the recaptcha is not well compiled an errors showed on top of the page instead near the filed captcha.
I really don't like this error because is not clear for who can have issue on understanding the language, where the issue is in the form.

Please how I can revert back to the old recaptcha error message showed under the recaptcha filed that was much more clear than now?

IS not an improvement remove red error near field that are not compiled correctly in the ticket creation or in any form.

I don't understand about code but seems you edited the file support-center-bundle/Resources/views/Knowledgebase/ticket.html.twig

uvdesk/support-center-bundle@62519db

From the code seems you add custom field check and if custom field is present you decide to show a different "bad" error on top instead of show an error near the field who is not correctly compiled.

This edit is not good if you never show in the page where the issue is.
Imagine a ticket creation that never show in red field email if email is not well compiled... will be a form more difficult to compile or will be more difficult for someone that are trying to open a ticket but his language is not supported or selected...

You removed the red error message that was near the ReCaptcha field so was more easy to understand why the ticket is not created and you moved this error on top of the page. If the user is not understanding the error or doesn't know what ReCaptcha mean, user will be not able to open ticket and will report ticket system are broken.

What other custom field will show error on top instead the better way to show error near the field that has errors?

I really need to remove this error from top and move again near the recaptcha, lease tell me how to do.
I looked in commits done but cannot understand nothing as there is no description of the changes.

Is much better have the recaptcha error like that:
SharedScreenshot

How can I return back to this in the latest stable version?
I suggest also to make this standard, i don't think is good show a different generic error on top just for custom field or for recpatcha. Custom field and recaptcha should show error near the field that has the issue, this is much more easy to understand instead of blocking the ticket creation with a generic error on top where if you cannot understand what the error message say, you will be not able to create a ticket.

@PeopleInside
Copy link
Contributor Author

The bad message error on top made also user loose his attachments.
I really don't like this update about moving the recaptcha error on top, I think is a really wrong update.

I not only want revert back but really suggest you to revert back in the official project... was better before: more understandable and without loosing of attachment,

@vipin-shrivastava
Copy link
Contributor

vipin-shrivastava commented Jun 24, 2021

@PeopleInside

Please follow the below steps :

  1. Update your support-center-bundel->controller->ticket.php file from here.
  2. Update your support-center-bundle->Resources->views->Knowledgebase->ticket.html.twig file from here.

After successfully update these two files. Please run php bin/console c:c .
Now, your mention issue should resolve.
If you still facing this issue or any issue please let me know.

@PeopleInside
Copy link
Contributor Author

Done i cloned the support-center-bundle
https://github.com/uvdesk/support-center-bundle

on the uvdesk main root done the php bin/console c:c

reload page https://helpdesk.peopleinside.it/it/usr/create-ticket/

but still see the captcha error on top.

Issue not resolved.

SharedScreenshot

SharedScreenshot2

@vipin-shrivastava
Copy link
Contributor

vipin-shrivastava commented Jun 24, 2021

@PeopleInside

I updated the above comment .

Please follow the below steps :

  1. Update your support-center-bundel->controller->ticket.php file from here.
  2. Update your support-center-bundle->Resources->views->Knowledgebase->ticket.html.twig file from here.

After successfully update these two files. Please run php bin/console c:c .
Now, your mention issue should resolve.
If you still facing this issue or any issue please let me know.

@PeopleInside
Copy link
Contributor Author

Thanks, seems work now.
Will this be integrated in UVdesk or I have to patch every time?

This resolve also other issue #420

Thank you!

@PeopleInside
Copy link
Contributor Author

PeopleInside commented Jun 24, 2021

@vipin-shrivastava thank you very much for your precious help!
I'm happy thanks to the fix now... I was waiting for this, thank you!

I will close this issue as soon I see fix here in GitHub

@vipin-shrivastava
Copy link
Contributor

@PeopleInside
we have merged these patches in the master branch. Please check.

@PeopleInside
Copy link
Contributor Author

Thank you @vipin-shrivastava :)
Can you help me to find the commits?

I'm looking for it but I cannot find
https://github.com/uvdesk/community-skeleton/commits/master

@vipin-shrivastava
Copy link
Contributor

@PeopleInside

below are the commits link :
uvdesk/support-center-bundle@15e0291
uvdesk/support-center-bundle@818e318

If you want any help . Please let me know .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants