Improvements on the error email sending

sqlshare_rest/util/dataset_queue.py

@@ -65,11 +65,11 @@ def email_owner_success(dataset):
             logger.error("Unable to send email to %s.  Error: %s" % (to,
                                                                      str(ex)))
 
-    def email_owner_failure(dataset):
-        to = dataset.owner.get_email()
+    def email_owner_failure(upload):
+        to = upload.owner.get_email()
         values = {}
 
-        values['name'] = dataset.name
+        values['name'] = upload.dataset_name
 
         text_version = render_to_string('uploaded_email/fail-text.html',
                                         values)
@@ -127,6 +127,7 @@ def start_upload(upload, background=True):
                 # relatively ok if that fails
                 pass
             finally:
+                upload = FileUpload.objects.get(pk=upload_id)
                 email_owner_failure(upload)
             import traceback
             tb = traceback.format_exc()
@@ -187,6 +188,7 @@ def process_upload(upload_id):
             upload.has_error = True
             upload.error = str(ex)
             upload.save()
+            raise
         finally:
             backend.close_user_connection(user)