added appReducer; created toggle feature, refactored component code #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruxuan
requested changes
Nov 13, 2018
frontend/src/App.js
Outdated
|
|
||
| class App extends Component { | ||
| render() { | ||
| console.log(this.props.view) |
frontend/src/reducers/appReducer.js
Outdated
| export default (state = initialState, action) => { | ||
| switch (action.type) { | ||
| case CHANGE_VIEW: | ||
| console.log(state.view); |
suzyng83209
reviewed
Nov 13, 2018
frontend/src/reducers/index.js
Outdated
| @@ -1,6 +1,8 @@ | |||
| import { combineReducers } from 'redux'; | |||
| import emptyReducer from './empty'; | |||
There was a problem hiding this comment.
Now that we actually have a normal reducer, could you go ahead and delete the empty reducer?
frontend/src/reducers/appReducer.js
Outdated
| import { CHANGE_VIEW } from '../actions/actionsTypes'; | ||
| import initialState from './initialState'; | ||
|
|
||
| export default (state = initialState, action) => { |
There was a problem hiding this comment.
Naming of this file is a little confusing. Could you name all reducers individual to their functions?
frontend/src/actions/appActions.js
Outdated
| @@ -0,0 +1,5 @@ | |||
| import * as types from './actionsTypes'; | |||
|
|
|||
| export function changeView(appView){ | |||
There was a problem hiding this comment.
Could you name the file with reference to the function of the actions? i.e changeViewAction.js
frontend/src/constants/constants.js
Outdated
| @@ -0,0 +1,2 @@ | |||
| export const MAP_VIEW = "MAP_VIEW"; | |||
There was a problem hiding this comment.
Could you name the file more relevant to the content? having constants.js file inside a constants folder is a little confusing
suzyng83209
approved these changes
Nov 15, 2018
suzyng83209
pushed a commit
that referenced
this pull request
Nov 27, 2018
* added appReducer; created toggle feature, refactored component code (#22) * added appReducer; created toggle feature, refactored component code * added color to denote selected toggle * added unselected color * removed loggin; renamed files for readability * added appReducer; created toggle feature, refactored component code (#22) * added appReducer; created toggle feature, refactored component code * added color to denote selected toggle * added unselected color * removed loggin; renamed files for readability * added initial setup for a searchbar * added all basic components to Sidebar * added full seach bar layout - refactored sidebar * added final structure of basic side bar * added basic ListViewCard to ListView * added mutiple ListViewCards * added footer position; added more styling * resized mapview to account for sidebar * added code for ListViewCards and styling * added icons to listViewCard * added appReducer; created toggle feature, refactored component code (#22) * added appReducer; created toggle feature, refactored component code * added color to denote selected toggle * added unselected color * removed loggin; renamed files for readability * added initial setup for a searchbar * added all basic components to Sidebar * added full seach bar layout - refactored sidebar * added final structure of basic side bar * added basic ListViewCard to ListView * added mutiple ListViewCards * added footer position; added more styling * resized mapview to account for sidebar * added code for ListViewCards and styling * added icons to listViewCard * changed login dialog to icon button; moved icon to search bar * fized uncuaght merge conflict * moved all assets into public * renamed login logo to keep styling * merge again
JerryXie98
added a commit
that referenced
this pull request
Dec 13, 2018
…or service provider. (#47) * added appReducer; created toggle feature, refactored component code (#22) * added appReducer; created toggle feature, refactored component code * added color to denote selected toggle * added unselected color * removed loggin; renamed files for readability * added bases for store selectCensusDivision reducer, highlight census division when clicked * binded onClick function; lost ability to track census division highlighting * added onFeature function to each census division * commit untracked action and reducer files * added highlight features for clicking * Added service provider population on map. * Removing unused components and C files? * Moved marker population function to improve performance. * Added popup for service provider markers. * Renaming of selectCensusDivision to changeSelectedCensusDivision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.