New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement admin add language modal #329
Conversation
Visit the preview URL for this PR (updated for commit e43f88c): https://planet-read-uwbp--pr329-languages-modal-cggmuney.web.app (expires Thu, 20 Jan 2022 16:00:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good (all listed testing steps work)! I love the phat button O.O
I noticed on the notion that if the admin inputs an existing language into the textarea, the textarea should turn red and the confirm button should be disabled. I didn't see this during testing.
theme="gray" | ||
variant="striped" | ||
width="100%" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: the existing languages table scrolls a bit strangely, maybe try something like:
<Box
borderRadius="10px"
boxShadow="0px 0px 2px grey"
height="300px"
overflow="auto"
>
<Table
marginTop="-10px"
size="sm"
theme="gray"
variant="striped"
width="100%"
>
good catch! try
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Notion ticket link
https://www.notion.so/uwblueprintexecs/a658c933d18c48d4b43fd99bda2bd3b4?v=ba22ac93d09040ff8219c60ac7caabdb&p=0bce90b6883443fdbc6ae18c0e945e63
Implementation description
Steps to test
What should reviewers focus on?
Checklist
docker exec -it planet-read_py-backend_1 /bin/bash -c "black . && isort --profile black ."
and I have generated new migrations:flask db migrate -m "<your message>"