Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Install eslint-config-next dev dependency #10

Merged
merged 1 commit into from
Jun 16, 2021
Merged

[Misc] Install eslint-config-next dev dependency #10

merged 1 commit into from
Jun 16, 2021

Conversation

OustanDing
Copy link
Member

@OustanDing OustanDing commented Jun 16, 2021 •
edited
Loading

Implementation description

Next.js runs ESlint during builds - we were missing the eslint-config-next dev dependency for this to take place

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@OustanDing OustanDing requested a review from a team June 16, 2021 02:07
@railway-app
Copy link

railway-app bot commented Jun 16, 2021 •
edited
Loading

This PR is being deployed to Railway 🚅

Live → richmond-centre-for-disability-pr-10.up.railway.app

[View Deployment]

@OustanDing OustanDing changed the title Install eslint-config-next dev dependency [Misc] Install eslint-config-next dev dependency Jun 16, 2021
@OustanDing OustanDing added the needs dev review Needs dev review label Jun 16, 2021
@OustanDing OustanDing merged commit 60de851 into staging Jun 16, 2021
@OustanDing OustanDing deleted the misc/install-eslint-next branch June 16, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffreyzhang2001 jeffreyzhang2001 jeffreyzhang2001 approved these changes

Assignees
No one assigned
Labels
needs dev review Needs dev review
Projects
None yet
Milestone
No milestone
2 participants
@OustanDing @jeffreyzhang2001