WIP: Add internal employee login page based on hi-fi designs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is being deployed to Railway 🚅 |
jeffreyzhang2001
added
don't merge
EmilioMena
reviewed
Jun 21, 2021
pages/login.tsx
Outdated
| </Flex> | ||
|
|
||
| {/* If NextAuth's callback doesn't contain a URL, auth (sending email) wasn't successful. */} | ||
| {!authState?.url ? ( |
There was a problem hiding this comment.
I was reading up on the nextAuth docs and was just curious - why did you use authState.url and not authState.ok here?
There was a problem hiding this comment.
authState.ok will always contain 200 (the HTTP code) if the user's login request is succesfully received by the NextAuth client, regardless of whether or not the user has a valid email. We need to check for url instead since it only gets returned when an actual login email gets sent out.
jeffreyzhang2001
force-pushed
the
jz/feature-add-login-page
branch
from
55c0d2c
to
130a62f
Compare
OustanDing
reviewed
Jun 23, 2021
| @@ -18,9 +18,9 @@ export default function Layout({ children, header = true, footer = true }: Props | |||
| <Meta /> | |||
| <Flex flexDirection="column" alignItems="center" minHeight="100vh"> | |||
| {header && <Header />} | |||
| <Box flexGrow={1} paddingTop={20}> | |||
| <Flex flexGrow={1} width="100%" justifyContent="center"> | |||
There was a problem hiding this comment.
For reference: Grid was not spanning 100% width. This was a necessary fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Build hi-fi login pages + logout button
Implementation description
DONE
WIP
Notes
Checklist
[Feature],[Improvement]or[Fix],