Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add new text styles #18

Merged
merged 3 commits into from
Jul 2, 2021
Merged

[Improvement] Add new text styles #18

merged 3 commits into from
Jul 2, 2021

Conversation

angeladietz
Copy link
Contributor

@angeladietz angeladietz commented Jun 29, 2021 •
edited
Loading

Notion ticket link

Update text styles in Chakra UI theme

Implementation description

  • Added new styles according to design system Figma to text-styles.ts

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@railway-app
Copy link

railway-app bot commented Jun 29, 2021 •
edited
Loading

This PR is being deployed to Railway 🚅

Live → richmond-centre-for-disability-pr-18.up.railway.app

[View Deployment]

@angeladietz angeladietz requested a review from a team June 29, 2021 03:01
@OustanDing OustanDing added the needs dev review Needs dev review label Jul 1, 2021
OustanDing
OustanDing reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@OustanDing OustanDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good so far. Some of the other text styles also changed in the design system Figma. Could you please do a quick scan of those and make sure that our existing text styles are up to date? Thanks in advance!

tools/theme/text-styles.ts Outdated Show resolved Hide resolved
@angeladietz @OustanDing
Change button-bold text style to button-semibold
29d741b 
Co-authored-by: Oustan Ding <oustan10@gmail.com>
OustanDing
OustanDing approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@OustanDing OustanDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angeladietz angeladietz merged commit 7c09289 into staging Jul 2, 2021
@angeladietz angeladietz deleted the ad/update-text-styles branch July 2, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OustanDing OustanDing OustanDing approved these changes

Assignees
No one assigned
Labels
needs dev review Needs dev review
Projects
None yet
Milestone
No milestone
2 participants
@angeladietz @OustanDing