Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Update Database schemas #24

Merged
merged 7 commits into from
Jul 15, 2021
Merged

[Improvement] Update Database schemas #24

merged 7 commits into from
Jul 15, 2021

Conversation

angeladietz
Copy link
Contributor

@angeladietz angeladietz commented Jul 10, 2021 •
edited
Loading

Notion ticket link

Add Address Line 2 to all DB schemas
Add gender text field to applicant, application for other genders
Add acceptedTOC field to applicant model

Implementation description

  • Added new fields to schema.sql and schema.graphql files

Notes

  • Everyone will need to run npx prisma db push locally to update their local db schemas once this PR is merged
  • Still a WIP because I haven't been able to get the schema.prisma file updated correctly. I think I may have a problem with my local db setup but if anyone has any tips on how to debug this so that the schema.prisma file will get updated please let me know!!

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@angeladietz angeladietz requested a review from j-bunk July 10, 2021 05:05
@railway-app
Copy link

railway-app bot commented Jul 10, 2021

This PR is being deployed to Railway 🚅

[View Deployment]

@railway-app
Copy link

railway-app bot commented Jul 10, 2021 •
edited
Loading

This PR is being deployed to Railway 🚅

Live → richmond-centre-for-disability-pr-24.up.railway.app

[View Deployment]

@angeladietz angeladietz requested a review from a team July 10, 2021 05:06
@angeladietz angeladietz added wip Work in progress needs dev review Needs dev review labels Jul 10, 2021
@angeladietz angeladietz removed the request for review from j-bunk July 10, 2021 05:06
@angeladietz angeladietz removed the wip Work in progress label Jul 14, 2021
@angeladietz angeladietz mentioned this pull request Jul 15, 2021
Merged
1 task
OustanDing
OustanDing approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@OustanDing OustanDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angeladietz angeladietz merged commit 7ece285 into staging Jul 15, 2021
@angeladietz angeladietz deleted the ad/database-schema-updates branch July 15, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OustanDing OustanDing OustanDing approved these changes

Assignees
No one assigned
Labels
needs dev review Needs dev review
Projects
None yet
Milestone
No milestone
2 participants
@angeladietz @OustanDing