Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Restrict permit expiry filter to only active permits #254

Merged

Conversation

OustanDing
Copy link
Member

@OustanDing OustanDing commented Aug 12, 2022

Notion ticket link

Ticket

Implementation description

Notes

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@OustanDing OustanDing self-assigned this Aug 12, 2022
@OustanDing OustanDing added needs dev review Needs dev review ready to merge ✅ Ready to merge (all reviews received) and removed needs dev review Needs dev review labels Aug 12, 2022
@OustanDing OustanDing merged commit 97854b7 into staging Aug 12, 2022
@OustanDing OustanDing deleted the od/fix/exclude-expired-permits-from-expiry-date-filter branch August 12, 2022 06:21
@OustanDing OustanDing mentioned this pull request Aug 12, 2022
3 tasks
OustanDing added a commit that referenced this pull request Aug 12, 2022
* [Improvement] Split address fields in permit holders report ([Improvement] Split address fields in permit holders report #253)
* [Fix] Restrict permit expiry filter to only active permits ([Fix] Restrict permit expiry filter to only active permits #254)
* [Fix] Standardize date formatting ([Fix] Standardize date formatting #252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge ✅ Ready to merge (all reviews received)
Projects
None yet
1 participant