Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix create new APP flow failing #263

Merged
merged 1 commit into from
Aug 17, 2022
Merged

[Fix] Fix create new APP flow failing #263

merged 1 commit into from
Aug 17, 2022

Conversation

OustanDing
Copy link
Member

@OustanDing OustanDing commented Aug 17, 2022 •
edited
Loading

Notion ticket link

Ticket

Implementation description

  • Mobility aids fields were not being included in input objects for Yup validation in GraphQL resolvers. Added the fields

Notes

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@OustanDing OustanDing self-assigned this Aug 17, 2022
@OustanDing OustanDing added the needs dev review Needs dev review label Aug 17, 2022
@OustanDing OustanDing merged commit 3e88ee5 into staging Aug 17, 2022
@OustanDing OustanDing deleted the od/fix/create-new-app-validation-failure branch August 17, 2022 05:16
@OustanDing OustanDing added ready to merge ✅ Ready to merge (all reviews received) and removed needs dev review Needs dev review labels Aug 18, 2022
@OustanDing OustanDing mentioned this pull request Aug 18, 2022
Merged
3 tasks
OustanDing added a commit that referenced this pull request Aug 18, 2022
@OustanDing
[Release] Version 0.0.6 (#264)
1f971f9 
* [Fix] Fix create new APP flow failing (#263)
* [Fix] Fix task log entries not showing (#262)
* [Fix] Fix inconsistent applicant flow copy (#261)
* [Fix] Fix accountant report aggregation values (#260)
* [Fix] Fix invoice records failing to be created (#259)
* [Fix] Fix permit holders not rendering if no recent permit (#258)
@OustanDing OustanDing mentioned this pull request Aug 26, 2022
Merged
3 tasks
OustanDing added a commit that referenced this pull request Aug 26, 2022
@OustanDing
[Release] Version 0.0.6 (#270)
12983bc 
* [Fix] Disable GQL playground and introspection in production (#269)
* [Fix] Specify node version in package.json (#268)
* [Fix] Allow GQL introspection (#267)
* [Fix] Re-enable GQL playground for debugging (#266)
* [Fix] Add port to Next start script (#265)
* [Fix] Fix create new APP flow failing (#263)
* [Fix] Fix task log entries not showing (#262)
* [Fix] Fix inconsistent applicant flow copy (#261)
* [Fix] Fix accountant report aggregation values (#260)
* [Fix] Fix invoice records failing to be created (#259)
* [Fix] Fix permit holders not rendering if no recent permit (#258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carelynntsai carelynntsai Awaiting requested review from carelynntsai

Assignees

@OustanDing OustanDing

Labels
ready to merge ✅ Ready to merge (all reviews received)
Projects
None yet
Milestone
No milestone
1 participant
@OustanDing